emacsorphanage / org-page

[INACTIVE] A static site generator based on Emacs and org mode.
674 stars 99 forks source link

Removes certain characters when generating URL. #212

Closed accidentalrebel closed 7 years ago

accidentalrebel commented 7 years ago

Some post titles will have certain characters that should not be part of a URL. This commit removes these unwanted characters for a cleaner generated URL.

Take this hypothetical post title for example:

What's up with"bagels"?: Aha! A complete guide."

The recent changes would generate the url:

whats-up-with-bagels-aha-a-complete-guide

Before it generated the following:

what's-up-with-\"bagels\"?-aha!-a-complete-guide.

I tested the other functions that uses the encode-string-to-url function. Everything seems to be working properly.

Tell me what you guys think. Or if there are other characters that should be removed when generating the URL.

sillykelvin commented 7 years ago

Merged, thanks!

accidentalrebel commented 7 years ago

Great, thanks!