search

emacsorphanage / org-page

[INACTIVE] A static site generator based on Emacs and org mode.
673 stars 99 forks source link

Feature/add republish all support #47

Closed xiaohanyu closed 11 years ago

xiaohanyu commented 11 years ago

code in this commit may be not suitable in the long run, but it works for the current time.

And I think op/do-publication should be refactored to support flexible publishing.

sillykelvin commented 11 years ago

I have reviewed your code, the function op/git-first-commit seems not so proper for this solution:

  1. we should try to make org-page platform independent, but in this function, utilities from *nix platform are used(tail, cut)
  2. as you described in the function's description, this is not the final way to solve subtree issue

In my opinion, there is a better way to implement the republish feature, do you still remember the function (defun op/publish-changes (all-list change-plist pub-root-dir)? We pass the all-files-list and changed-files-list to it, so, for republish feature, we can just pass all-files-list to both all-list and change-plist.

I think this is much better and is a proper solution, right?

sillykelvin commented 11 years ago

This feature is implemented, close this issue.