search

emacsorphanage / org-page

[INACTIVE] A static site generator based on Emacs and org mode.
673 stars 99 forks source link

Decrease the spacing between lines of code block? #95

Open xuchunyang opened 9 years ago

xuchunyang commented 9 years ago

I'm using org-page's default theme (since the remaining two theme is not useable on some level), and I find the spacing between lines of code block is much bigger than usual, what do you think about this? Is a bigger line spacing good for reading in browser?

sillykelvin commented 9 years ago

I am not a CSS guy, so I copied this theme from @mdo. You have the following two choices:

  1. decrease the spacing and send me a pull request
  2. create you own copy of this theme, and adjust the value in that copy. and set the following two variables to make org-page use your own theme(assuming you put the theme directory at ~/my-theme/mdo-modified):
(setq op/theme-root-directory "~/my-theme/")
(setq op/theme 'mdo-modified)

Hope that helps.

xuchunyang commented 9 years ago

I am not a CSS guy

Me neither, I'm afraid this task is beyond me. God help us all.

Fell free to close this issue if you have no any plan to fix it.

sillykelvin commented 9 years ago

I did some adjustment, does it look better now?

xuchunyang commented 9 years ago

Not sure. Below is my test, the left is the latest org-page and the right is the older version screen shot 2014-12-27 at 6 00 09 pm The font size of code block is bigger now, which is what you want. But I think increasing font size may cause long line broken much often, which will obviously reduce readability. Maybe you can try some code friendly fonts.

heikkil commented 9 years ago

My two cents worth:

In my opinion in the pre/code block both font size and spacing are too big.

Without changing the body text size (using sans serif font), these settings work for me:

    font-size: 14px;
    line-height: 18px;