search

emad-elsaid / devtools

A set of simple tools every developer needs, collected in one application.
http://www.emadelsaid.com/devtools
MIT License
15 stars 6 forks source link

Adding Textarea length field #15

Closed MohamedBassem closed 8 years ago

MohamedBassem commented 8 years ago

According to our discussion in #14, This pull request adds a length field under the bottom right corner of the text field. Not sure what should the color/text of the field be, but this can be easily changed. I've never used ember before so feel free to comment on whatever you feel can be done better :smile:

screenshot from 2015-12-13 16-10-26

Edit : Adding the image.

emad-elsaid commented 8 years ago

Pretty clean code, i'm fascinated by following the same coding style, great job, i have some design comments that will finalize it:

  1. we should remove "Length :" from the indicator, that will leave us with the number only.
  2. we should pull the div up to overlay the textarea, it should be a number on the textarea itself.
  3. we should add a "padding-bottom" to the textarea so that the last line in it doesn't intersect with the length number.

otherwise everything is done perfectly, thank you.

MohamedBassem commented 8 years ago

Thanks :D I tried the overlay thing. The problem is that when you scroll, the padding doesn't help anymore.

screenshot from 2015-12-13 16-37-22

emad-elsaid commented 8 years ago

Aha i get it, ok, let me merge it and work on that, i may find some kind of solution for it.