search

emad-elsaid / devtools

A set of simple tools every developer needs, collected in one application.
http://www.emadelsaid.com/devtools
MIT License
15 stars 6 forks source link

Fixing bind-attr deprecation #16

Closed MohamedBassem closed 8 years ago

MohamedBassem commented 8 years ago

While working on the previous pull request, I got this deprecation warning:

DEPRECATION: The `bind-attr` helper ('devtools/templates/components/devtools-textarea.hbs' @ L7:C15) is deprecated in favor of HTMLBars-style bound attributes.
    {anonymous}(/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:11425:15)
    Walker.visit (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:17985:7)
    visitors.ElementNode (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:18001:16)
    Walker.children (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:18018:7)
    Walker.visit (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:17986:12)
    visitors.ElementNode (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:18001:16)
    Walker.children (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:18018:7)
    Walker.visit (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:17986:12)
    visitors.Program (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:17995:16)
    Walker.children (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:18018:7)
    Walker.visit (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:17986:12)
    visitors.BlockStatement (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:18006:14)
    Walker.children (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:18018:7)
    Walker.visit (/home/mohamedbassem/repos/devtools/bower_components/ember/ember-template-compiler.js:17986:12)

With a quick googling I found this : http://emberjs.com/blog/2015/03/27/ember-1-11-0-released.html It suggests the fix that I pull requested.

emad-elsaid commented 8 years ago

Well, this is great, i have noticed it before and forgot to fix it, i also wanted to upgrade ember-cli and ember versions, but i'm afraid so much that it would break something :smile: