search

emad-elsaid / xlog

💥 Personal knowledge management application. One binary HTTP server. works in any Markdown directory. autolinks pages, hashtags, auto preview images link, screenshare, screenshot, camera recording and audio recording embedded in the note. and fast search through the KB
https://xlog.emadelsaid.com
MIT License
154 stars 15 forks source link

link_preview.go: fix Twitter regexp #67

Closed disconnect3d closed 2 months ago

disconnect3d commented 3 months ago

This commit fixes the Twitter regex by escaping a dot in .com.

Before:

image

After:

image
ccoVeille commented 3 months ago

While you are working on this, shouldn't we add support for x.com?

disconnect3d commented 3 months ago

Hi, I found this randomly via grep.app and decided to send a fix. Please merge it and implement support for x.com later on if you want it.

On Sat, 3 Aug 2024 at 21:25, ccoVeille @.***> wrote:

While you are working on this, shouldn't we add support for x.com?

— Reply to this email directly, view it on GitHub https://github.com/emad-elsaid/xlog/pull/67#issuecomment-2267111215, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMLWCTJQGGSY2J2WAO4TGTZPUVBDAVCNFSM6AAAAABL6EAEKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRXGEYTCMRRGU . You are receiving this because you authored the thread.Message ID: @.***>

ccoVeille commented 3 months ago

I'm a random guy watching the repository. Let's wait a maintainer to reply you

emad-elsaid commented 2 months ago

added support for x.com links. weirdly the x.com tweets is embeded with twitter.com domain still

00a680c526b5fd7b90ad6cf257eac5a32406132f