resolve parameters in Page.url

[emadalam]

From one of the PRs https://github.com/emadalam/atvjs/pull/12

This allows to build URLs for pages dynamically based on the options.urlParams that are handed over to the page. Uses the same node-module that express uses, so the very same syntax applies. For example use “http://httpbin.org/get?test=:test” with options = {urlParams: {test: true}} to get “http://httpbin.org/get?test=true”.

• [ ] evaluate configuration format
• [ ] implement a stripped down version without using path-to-regexp

Handy code snippet

function toQueryString(obj) {
    return (
        _.map(obj, (v, k) => {
            if (_.isArray(v)) {
                return (_.map(v, (av) => `${k}[]=${av}`)).join('&');
            } else {
                return `${encodeURIComponent(k)}=${encodeURIComponent(v)}`;
            }
        })
    ).join('&');
}

function toUrl(url = '', params = {}) {
    let q = toQueryString(params);
    let urlBuffer = [url];
    if (q) {
        urlBuffer.push(/\?.+$/.test(url) ? `&${q}` : `?${q}`);
    }
    return urlBuffer.join('');
}

[iamrahulrnair]

function toQueryString(obj) { 
   return _.map(obj, (v, k) => { 
  if (_.isArray(v)) { 
return _.map(v, (av) =>${k}[]=${av}).join('&'); 
} else { return 
   ${encodeURIComponent(k)}=${encodeURIComponent(v)}`;
    }
  }).join('&');
}

function toUrl(url = '', params = { } ) {
let q = toQueryString(params);
let urlBuffer = url;

if (q) {
urlBuffer += '?' + q;
   }
  return urlBuffer;
 }

This felt like an easy fix to get rid of reg-exp, if am wrong care to specify why the reg-exp needed in the first place?