Open Chinney opened 6 years ago
Also consider this: https://github.com/reactjs/react-rails/issues/825
Seems like this is an deprecation issue. Components like React.PropTypes
and React.createClass
are no longer part of the main react
module. instead they have been moved into seperate modules. I fixed it locally. I installed and used the following packages insted:
react
proto-types
create-react-class
I know this is not a pretty solution but I'm kinda new to react. Maybe someone with more experience have a look into this and use the mailspring react components instead of local ones? Cheers!
@Striffly Your fork works for me, although I get this minor layout issue where the unread icon overlaps over the name of the email sender.
I'm on the latest Mailspring (Version 1.4.2).
@Striffly Your fork works for me, although I get this minor layout issue where the unread icon overlaps over the name of the email sender.
I'm on the latest Mailspring (Version 1.4.2).
Fixed ! https://github.com/Striffly/mailspring-avatars/commit/876280b676c1308b3280de05a646737932bd7807
Hi, thanks a lot @Striffly for adapting this plugin! It doesn't seem to work with Mailspring 1.6.1 though, I don't have any avatars appear in my email list. Does it work for you?
Hi @paulgaumer
Same thing for me, I don't find solution for the moment 😕
Plugin fixed here : https://github.com/Striffly/mailspring-avatars Due to the inactivity of the author, please go here for future issues.
The plugin is not working for me (OS: Ubuntu 16.04)
I tracked it down to the
React.Proptype
component which seems to beundefined
inavatar-image.jsx
. I am currently trying to fix it.Console Output: