search

email-frappejs / frappejs

Node + Electron + Vue based metadata web framework (inspired by Frappe)
0 stars 2 forks source link

Issues wih config.json #3

Open accakks opened 6 years ago

accakks commented 6 years ago

Can you check config.json file? @inishchith

inishchith commented 6 years ago

As in ? 🙈

accakks commented 6 years ago

1) I've added new credential fields i used in sending.js, some are common with receiver.js but names are different, we can adopt common naming. 2) you've added port and host in config.json, which are different as in case of smtp. Can you either include those in receiver.js or should we include both separately in config.json like host_smtp , host_imap etc

inishchith commented 6 years ago

I think for now, just have 2 different config files as we're just testing stuff out. Later we can discuss this with mentors .

inishchith commented 6 years ago

@accakks @meets2tarun I've added model here . Some fields are incomplete though . we'll discuss that in tomorrow's call . After successfully completing email model , we can remove config.json .

inishchith commented 6 years ago

@accakks is Email Model this complete with the receiving details ?

accakks commented 6 years ago

Receiving details meaning To, from, cc, bcc, and message contents?