search

email-markup-consortium / emailmarkup.org

https://emailmarkup.org
6 stars 4 forks source link

Insufficient colour contrast #10

Closed husseinalhammad closed 2 years ago

husseinalhammad commented 2 years ago

@M-J-Robbins highlighted an issue with colour contrast in #9:

One small issue is the contrast of white text on the light green (#3dbdb6) but I'd be happy for us to deal with that later so we can get this out.

husseinalhammad commented 2 years ago

@dylanatsmith has also flagged this in https://github.com/email-markup-consortium/email-markup-consortium.github.io/pull/13#issuecomment-1137092054

dylanatsmith commented 2 years ago

Hadn't seen this issue at the time. 👍🏻

husseinalhammad commented 2 years ago

@megbosh can you please help us figure out a different colour combination here?

megbosh commented 2 years ago

Here's a screenshot of the page with a new background color. The bg color is #E9EAF7 and then we'd change the text color on those backgrounds to match the other dark text, and swap the white logo at the top to the full color version. Thoughts?

screencapture-emailmarkup-org-2022-06-03-15_15_47

M-J-Robbins commented 2 years ago

Yeah looks good to me, although I did a quick look on the site with dev tools and #E9EAF7 looks more purple on my screen but a bit more blue on your screenshot. Bit strange, not sure why that's happening. Could be my eyes are off a little.

EMC home page with new colours
megbosh commented 2 years ago

Oh yeah, that's interesting. Do you want to keep the color as is or look for a different one? Both shades work, it could be a difference in monitor set up?

M-J-Robbins commented 2 years ago

I'm happy with the colour change, whichever way it comes out.