email-markup-consortium / emailmarkup.org

https://emailmarkup.org
6 stars 4 forks source link

Site overhaul #38

Closed husseinalhammad closed 1 year ago

husseinalhammad commented 2 years ago

This is a bigger PR than I like, but there are some multiple blockers and due to limited time I grouped them all together.

This adds

Other changes

netlify[bot] commented 2 years ago

Deploy Preview for emailmarkup ready!

Name Link
Latest commit 18359b524b4f5b26e9d9a3c05ef3607b37118c44
Latest deploy log https://app.netlify.com/sites/emailmarkup/deploys/6329cfd9c04dac0008a7e305
Deploy Preview https://deploy-preview-38--emailmarkup.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

husseinalhammad commented 1 year ago

Are we removing the RSS feed link intentionally?

We can add it back to the footer.

The dark mode theme doesn't seem to align with the light mode theme. Should we have @megbosh take a look at it?

Tried darker shades of green, but looked off. Happy for @megbosh to help with this.

The new header logo at 120px width appears to have some legibility issues with the "Markup Consortium" section. Should we try to set it to 50px height (+ no defined width) like the original site instead?

Yeah can be done. Even at 45px height it looks readable to me (50px seems a tiny bit too large?)

More of a philosophical question about how we're heading. Do we really want to bury the membership forms and not have any link to them on the frontpage at all? Is this something we should discuss this at the Member's meeting perhaps?

We initially needed people to join. We kept the barrier to join very low. And this approach succeeded in driving >70 members to join (not counting people who raised their hands as supporters).

We no longer need quantity. We can focus on getting the most out of these 70 members during this phase. The number of contributing members (during meetings, in written discussions or by doing work) is a lot smaller than 70.

I think with the new approach we may get fewer applicants overall, but the percentage of new applicants who are genuinely interested in contributing (meetings, written discussions or work) would be higher - which is what we need after all.

A bit of a "nice to have", but is it possible to make the header nav sticky?

Can do

M-J-Robbins commented 1 year ago

Hi sorry for the delay, loving it. A few notes

husseinalhammad commented 1 year ago

Sponsor logos don’t looks quite right in darkmode

This was highly inspired by the Vue (https://vuejs.org/) and Vite (https://vitejs.dev/) sites, but I agree these look a bit off (it could be because I am using a darker background colour). Reverted to the light grey BG and coloured logos.