Fixes #32 to make report location required

email2vimalraj / CucumberExtentReporter

A plugin to generate the cucumber jvm custom html report using ExtentsReport

http://www.vimalselvam.com/cucumber-extent-reporter/

MIT License

58 stars 75 forks source link

Fixes #32 to make report location required #34

Closed haroon-sheikh closed 7 years ago

email2vimalraj commented 7 years ago

@haroon-sheikh : Thanks for the PR. If I understand it correctly, you are making the report location mandatory from the user, right?

Any specific reason why it is has to be mandatory. Because, we can always fallback to default location when the user doesn't specify the parameter.

Also, there is a bug in cucumber related to this for which I had sent a PR already. In case you are interested, kindly have a look: https://github.com/cucumber/cucumber-jvm/pull/1105

haroon-sheikh commented 7 years ago

@email2vimalraj I understand it's currently a bug within cucumber-jvm - but meanwhile looking at the number of pull requests open. I dont believe it'll get merged in very soon.

However, I think it just makes sense to let the user decide where the report should goto similar to how html report and json formatters currently work.