emailjs / emailjs-imap-client

Low-level JS IMAP client for all your IMAP needs.
MIT License
553 stars 122 forks source link

ANNOUNCEMENT: EmailJS 2017+ #158

Closed felixhammerl closed 6 years ago

felixhammerl commented 6 years ago

Hi y'all,

how do you use the email js libs? I've been on a longer hiatus, but I'm planning on dropping in again more in the future. For that reason, I'd like to re-assess the scope of this project, since some of the basic assumptions changed:

What do y'all think about this? On which platforms are you using emailjs?

EDIT: This happens in a major version bump, so y'all can continue pretty much undisturbed.

nifgraup commented 6 years ago

Sounds good. Getting 2 spaces in return for losing the semi colon seems like a fair trade, but I'm not going to bikeshed JS lint style :). We use emailjs at Vivaldi with the chrome.socket API. It is still working in the Chromium project but eventually it will go away. That means either adopting chrome.socket or switching to something else.

felixhammerl commented 6 years ago

4 or 2 spaces, I don't care either. But it's a package deal and standardjs is a pretty good linter with a decent code style that works out of the box, so i'll take the 2 spaces :)

I'll see to it that compatibility need not be unnecessarily broken. It the socket shim causes problems, I'll think about removing it. Downside is the cost of having to rewrite the socket code. Let's cross that bridge when we get there :)

felixhammerl commented 6 years ago

@nifgraup found a way to make the tcp socket work after all :) https://github.com/emailjs/emailjs-tcp-socket