emaloney / CleanroomLogger

CleanroomLogger provides an extensible Swift-based logging API that is simple, lightweight and performant
MIT License
1.32k stars 154 forks source link

Enable arm64-simulator slice creation in XCFramework by Carthage #107

Open Gucky opened 3 years ago

Gucky commented 3 years ago

Carthage didn't create an ARM64 slice for simulators because the xcconfig file did specify which VALID_ARCHS should be build. Removing that specification did enable Carthage to build a slice for ARM64-simulator. That was a huge problem because on M1/Apple Silicon machines generation of code coverage reports for tests is only possible when running an ARM64 app in the simulator. Without this change one could explore ARM for simulators and only run on x64 but loose code coverage with that trick. VALID_ARCHS is outdated and no longer available/visible in current Xcode versions anyway.