search

emaloney / CleanroomLogger

CleanroomLogger provides an extensible Swift-based logging API that is simple, lightweight and performant
MIT License
1.32k stars 153 forks source link

Couldn't get it to build under Swift Package Manager #70

Closed maximveksler closed 7 years ago

maximveksler commented 7 years ago

Fixing 2 issues:

  1. Bad syntax in Package.swift, causing 
Packages/CleanroomLogger.git/Package.swift:5:1: error: unexpected ',' separator
)
^
Can't parse Package.swift manifest file because it contains invalid format. Fix Package.swift file format and try again.
  1. Unexpected placement of Unit tests, vs. what is expected by SPM, causing:
Cloning https://github.com/maximveksler/CleanroomLogger.git
HEAD is now at deb26c0 Fixing package manager breaking the build
Resolved version: 5.0.2
error: the package has an unsupported layout, unexpected source file(s) found: /Users/maximveksler/Project/[REDACTED]/Collection/Packages/CleanroomLogger-5.0.2/Tests/LogSeverityTests.swift, /Users/maximveksler/Project/[REDACTED]/Collection/Packages/CleanroomLogger-5.0.2/Tests/LoggingTests.swift
emaloney commented 7 years ago

Thanks a lot for the heads-up on these problems.

emaloney commented 7 years ago

Maxim,

I didn't merge this in directly but I made the changes necessary to satisfy both Swift Package Manager and Xcode. I just released it as version 5.0.2. Thanks again for your pull request!

E.