search

emancu / toml-rb

A parser for TOML using Citrus library.
MIT License
104 stars 39 forks source link

Fix comment parsing #111

Closed greysteil closed 6 years ago

greysteil commented 6 years ago

First up, thanks for toml-rb! I use it in Dependabot and it's rad.

I came across a valid TOML file that it couldn't parse (this one) and dug into how the grammars work. This PR fixes the issue, which was that linespaces between comment lines were causing issues. I've added a test, too.

To make it easier for others to get up-and-running hacking on the library I've also committed the setup steps I made (i.e., adding support for Bundler) and cleaned up some deprecation warnings.

greysteil commented 6 years ago

Updated to just be the comment parsing change and a very minor test cleanup - should be easy to merge now 🙂.

greysteil commented 6 years ago

Thanks for the quick turn-around! ⚡️

emancu commented 6 years ago

@greysteil new version pushed, you can update your gem now ;)

emancu commented 6 years ago

Thank you so much for taking care of this bug, and cleaning the warnings!