Code Review

[armaaar]

• You didn't fork our repo
• You downloaded the project instead of cloning it
• You added all changes into a single commit
• You didn't pay attention to eslint
• You should have returned the initial state if no local storage found https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/store/index.jsx#L18
• deconstruct props when possible https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoList/index.jsx#L7
• Remove unused imports https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/pages/index.jsx#L4
• Don't use event to bind data. use state instead https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L14
• Unnecessary hook, You already defined the same value as initial value for your state https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L10
• Bad function name https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L20
• Unnecessary comment https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L30
• Never use inline styles without a proper reason. use class names instead https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L46
• Either remove unclickable call to actions or change their styles https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L48

[emanelshawwa]

Dear Eng Ahmed, I hope this email finds you well Thank you for your comments , I will solve these issues and send email to you tomorrow Best regards Eman Elshawwa

On Sat, 17 Oct 2020, 2:16 pm Ahmed Rafik Ibrahim, notifications@github.com wrote:

• You didn't fork our repo
• You downloaded the project instead of cloning it
• You added all changes into a single commit
• You didn't pay attention to eslint

• You should have returned the initial state if no local storage found

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/store/index.jsx#L18

• deconstruct props when possible

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoList/index.jsx#L7

• Remove unused imports

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/pages/index.jsx#L4

• Don't use event to bind data. use state instead

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L14

• Unnecessary hook, You already defined the same value as initial value for your state

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L10

• Bad function name

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L20

• Unnecessary comment

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L30

• Never use inline styles without a proper reason. use class names instead

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L46

• Either remove unclickable call to actions or change their styles

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L48

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/emanelshawwa/React-todos-list/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK54E6WZZI234URGIKXZIDSLGDLRANCNFSM4SUKLNBA .

[emanelshawwa]

Dear Eng Ahmed, I hope this email finds you well I solved the issues , I forked the repo and this is the link of forked repo : https://github.com/emanelshawwa/react-todos-code-challenge Best regards Eman Elshawwa

On Sat, Oct 17, 2020 at 5:08 PM Eman Elshawwa eman.elshawwa@gmail.com wrote:

Dear Eng Ahmed, I hope this email finds you well Thank you for your comments , I will solve these issues and send email to you tomorrow Best regards Eman Elshawwa

On Sat, 17 Oct 2020, 2:16 pm Ahmed Rafik Ibrahim, < notifications@github.com> wrote:

• You didn't fork our repo
• You downloaded the project instead of cloning it
• You added all changes into a single commit
• You didn't pay attention to eslint

• You should have returned the initial state if no local storage found

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/store/index.jsx#L18

• deconstruct props when possible

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoList/index.jsx#L7

• Remove unused imports

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/pages/index.jsx#L4

• Don't use event to bind data. use state instead

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L14

• Unnecessary hook, You already defined the same value as initial value for your state

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L10

• Bad function name

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L20

• Unnecessary comment

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L30

• Never use inline styles without a proper reason. use class names instead

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L46

• Either remove unclickable call to actions or change their styles

  https://github.com/emanelshawwa/React-todos-list/blob/38e290953673ba205f7fbceb2958f1c4721242ef/src/components/TodoItem/index.jsx#L48

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/emanelshawwa/React-todos-list/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGK54E6WZZI234URGIKXZIDSLGDLRANCNFSM4SUKLNBA .