search

emanjavacas / pie

A fully-fledge PyTorch package for Morphological Analysis, tailored to morphologically rich and historical languages.
MIT License
22 stars 10 forks source link

Make webapp a function #12

Closed PonteIneptique closed 5 years ago

PonteIneptique commented 5 years ago

Right now, the webapp is run from webapp.py. It contains directly the tokenizer. While keeping the ability to use the webapp in a simply python webapp.py, it should be possible to create the application passing it another tokenizer if deemed necessary.

emanjavacas commented 5 years ago

Yes, I agree. It is though a bit tricky because you should ensure compatible tokenization with the training data, which is not always possible, since it's not clear what tokenizer was used for most training sets. But yes, feel free to add something like that.

PonteIneptique commented 5 years ago

I think we can close this if you are happy with the resulting PR :)

emanjavacas commented 5 years ago

Ye, it looks good, thanks!