search

emanjavacas / pie

A fully-fledge PyTorch package for Morphological Analysis, tailored to morphologically rich and historical languages.
MIT License
22 stars 10 forks source link

Packaging ? #17

Closed PonteIneptique closed 5 years ago

PonteIneptique commented 5 years ago

Hey, again, I think this would be great to have something pip-able but I know you had your concern about it. I feel like torch on pip is in a good state. What do you think ? Cheers,

emanjavacas commented 5 years ago

Hi,

yes, that was mostly my concern, some of the dependencies need a bit of tweaking. But I wouldn't be against packaging if this would mean that more people get to try the package. The other thing is providing all the scripts (train.py, tag.py, evaluate.py, etc...). If you want to take care of that, I am fine.

PonteIneptique commented 5 years ago

I love packaging. See you next week for a PR ;)