search

emanjavacas / pie

A fully-fledge PyTorch package for Morphological Analysis, tailored to morphologically rich and historical languages.
MIT License
22 stars 10 forks source link

Torch 1.3 #37

Closed PonteIneptique closed 4 years ago

PonteIneptique commented 4 years ago

Hey ! I spent some time looking at what could be blocking >= 1.2. Most of it was the use of int mask used as boolean, which was touched by a breaking change inserted in 1.2.0 ( https://github.com/pytorch/pytorch/releases/tag/v1.2.0 ) I found two concerned occurrences, trained with my usual models as well as tagged. This does not cover all models but gives a general robustness.

All other masks seems to use the numerical value rather than the boolean one.

emanjavacas commented 4 years ago

Hey thanks for the PR! I haven't been using pytorch > 1.0 and I am not up to date with these changes. Please have a look at the comment (mostly about readability).

PonteIneptique commented 4 years ago

Here you go ! Thanks for the quick answer :)

emanjavacas commented 4 years ago

Thanks for the PR!

PonteIneptique commented 4 years ago

Thanks for the quick management ;) When you have time, a bump to "0.2.6" would be neat ;)