search

emanjavacas / pie

A fully-fledge PyTorch package for Morphological Analysis, tailored to morphologically rich and historical languages.
MIT License
22 stars 10 forks source link

Transformer package ability #40

Closed PonteIneptique closed 4 years ago

PonteIneptique commented 4 years ago

Hey there, After spending some time, I think this it it. The system is thought to be able to work with other kind of embeddings as well. Note that I fixed two issues with crf (.t() and a not missing before a highway declaration).

emanjavacas commented 4 years ago

Hey. Thanks for the PR. Have you already tested it/gotten some results? Btw. I noticed you weren't listed as author, which I thought it's quite unfair, so I have updated the setup.py file and also bumped to a new version.

PonteIneptique commented 4 years ago

Thanks for the setup :) The current thing works, but I am not completely satisfied with some architectural choices, I'll probably ping you on that ;)