search

emanjavacas / pie

A fully-fledge PyTorch package for Morphological Analysis, tailored to morphologically rich and historical languages.
MIT License
22 stars 10 forks source link

(Improvement) Use print when verbose is selected rather than logging.… #62

Closed PonteIneptique closed 4 years ago

PonteIneptique commented 4 years ago

…info

If people use verbose, they probably expect a lot of output.

emanjavacas commented 4 years ago

Hey. Verbose was only controlling a couple of training corpus stats. It is true that it's not very thorough right now. Still, I'd prefer to handle this through logging levels. Ideally we should just remove all print statements and route that through logging.info...

PonteIneptique commented 4 years ago

I have had massive issue with logging for some reason, which I still don't get. I have no problem with using logging but currently, using 'screen' over ssh, somehow, nothing is printed. I don't know the source of the problem, which part is the cause of it, but this makes things print at least...

Le mer. 6 mai 2020 à 6:10 PM, Enrique Manjavacas notifications@github.com a écrit :

Hey. Verbose was only controlling a couple of training corpus stats. It is true that it's not very thorough right now. Still, I'd prefer to handle this through logging levels. Ideally we should just remove all print statements and route that through logging.info...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emanjavacas/pie/pull/62#issuecomment-624742153, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOXEZUXM4MKBDB3XV2VAOTRQGDXNANCNFSM4M2PTPOA .

emanjavacas commented 4 years ago

As far as I understand logging output to stderr by default. I think you just have to redirect it stdout and should be easy to capture. But I might be missing something.

On Wed, May 6, 2020 at 6:18 PM Thibault Clérice notifications@github.com wrote:

I have had massive issue with logging for some reason, which I still don't get. I have no problem with using logging but currently, using 'screen' over ssh, somehow, nothing is printed. I don't know the source of the problem, which part is the cause of it, but this makes things print at least...

Le mer. 6 mai 2020 à 6:10 PM, Enrique Manjavacas <notifications@github.com

a écrit :

Hey. Verbose was only controlling a couple of training corpus stats. It is true that it's not very thorough right now. Still, I'd prefer to handle this through logging levels. Ideally we should just remove all print statements and route that through logging.info...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emanjavacas/pie/pull/62#issuecomment-624742153, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAOXEZUXM4MKBDB3XV2VAOTRQGDXNANCNFSM4M2PTPOA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/emanjavacas/pie/pull/62#issuecomment-624746500, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPIPI3WV6OJQHKBDKISIKLRQGEU3ANCNFSM4M2PTPOA .

-- Enrique Manjavacas