Add doc-level organization

emanjavacas / weasimov

Code for the "AsiBot" project

MIT License

0 stars 0 forks source link

Add doc-level organization #29

Closed emanjavacas closed 7 years ago

emanjavacas commented 7 years ago

in the future, the app should give you the ability to open different documents (in case you want to have one for drafting, another one to write your new novel, another one for your ERC grant, etc...)

burtenshaw commented 7 years ago

Database

[x] Add document level classification to the database
[x] Text should have a unique ID.

Interface

[x] Simple dropdown of documents.
[ ] ~Basic doc info; word count, date.~
[x] New doc Button.
[x] Make new doc text input span full parent component width @burtenshaw
[x] Add front-end document delete functionality

emanjavacas commented 7 years ago

issues to discuss

[x] interval saving: save all docs or only current one (the former is slighty safer, but much more inefficient given unbounded number of docs)
[x] probably each doc should have its own editorState, this means quite some bit of rewritting but it will be less bug-prone. Currently, many events are triggered on editorstate change, and moving to a different doc will trigger such a change. Apart from that, having different editorStates will ensure that all selection data is also doc dependent
[ ] validation on document names, not too long
[ ] ~for simplicity I've put the documents dropdown controller to the navbar, I thing a nicer idea would be to have them to the right side of the text editor in a vertical layout (similar to the style buttons)~

fbkarsdorp commented 7 years ago

I'd say, save only the current one, and make sure to save it again when moving to another tab or when closing the app. What's easier?

emanjavacas commented 7 years ago

yeh that sounds like a better solution

burtenshaw commented 7 years ago

A save button would probably also make sense now. For piece of mind.

emanjavacas commented 7 years ago

have a first draft working, can't see any bugs in a short test.. but sure there will be

fbkarsdorp commented 7 years ago

Awesome! Did you make changes to the database? I tried the automated migration, but we're probably better of to do it manually...

emanjavacas commented 7 years ago

I did many, so we will have to be very careful with the migration

fbkarsdorp commented 7 years ago

OK. A lot of testing then.

emanjavacas commented 7 years ago

the major changes is a new model Doc and the addition of doc_id to the other models. I've rename a couple of columns that were misleading and rearranged generation to account for the deletion of suggestions. Also given that addition and deletion can happen in different docs, I also had to add a column (action_doc_id) to register that...

We will have to test that the db is registering all these thing at the right moment with the right data... I think we are transitioning from toy-app to a-bit-more-serious-app

emanjavacas commented 7 years ago

closing this since it only needs testing