Feature/websocket - Githubissues

emanjavacas / weasimov

Code for the "AsiBot" project

MIT License

0 stars 0 forks source link

Feature/websocket #54

Closed emanjavacas closed 7 years ago

emanjavacas commented 7 years ago

Long standing... We should probably wait to invite Bastian until this is merged.

emanjavacas commented 7 years ago

There were only two conflicts, and they were easy to resolve. This should just be tested and merged.

fbkarsdorp commented 7 years ago

I'll start testing this today.

fbkarsdorp commented 7 years ago

Some observations:

[x] Pressing enter after changing the title of a document has no result.
[ ] I'm not sure we actually need an interface to the multiple documents. Wouldn't it confuse the users? (What do you think, @BSTN)
[x] Links in monitor panel don't work.
[x] The probabilities of generations are much lower than before. (I'm using the same models as in the app currently running on AWS, but with the latest version of seqmod. Have a look at the screenshot.

emanjavacas commented 7 years ago

re 1: the bug is that we should escape enter or force a save on enter. Currently it gets saved if you click on save. re 2: whatever @BSTN thinks. I'd still want to keep it in the non-public version. re 3: which links more exactly? I don't seem to see the issue. re 4: there are many issues with the way we are handling the models. Probability depends on the creativity slider, so in order to debug that you should always make sure to use the same value. Same for the model. And in general, we should've stuck to a single seqmod version for weasimov. It's really hard for me to keep this dual developing track where I track bugs for weasimov and keep using it for my daily work. I would say: try to find the version of seqmod that we were using back then and stick to it.

fbkarsdorp commented 7 years ago

Good suggestions! Thanks. I'll try to fix them.

fbkarsdorp commented 7 years ago

For reference, current AWS seqmod is running commit 7d8c976a03836fcf347395c192987dba531c2144

emanjavacas commented 7 years ago

Nice that you are taking care of this. I hope the code is readable, as far as I remember I basically followed the same style and conventions as previously.

fbkarsdorp commented 7 years ago

OK. Did some more testing and I believe this is ready to be merged.