emanondev / ItemEdit

GNU General Public License v3.0
17 stars 14 forks source link

Some suggestions for "ItemEdit" #2

Open Annijang opened 2 years ago

Annijang commented 2 years ago

The work is great, can you add edit blocks and Entity? For example: chest, jukebox, zombie, vex... just like the "In-Game NBTEdit" mod. I checked the jar and found "languages", how should I upload to you the "zh_cn" file that I am about to complete?

emanondev commented 2 years ago

can you provide a link or a video of "In-Game NBTEdit" ? I can add a command to edit blocks and entities

for the language i use a simplified system which uses only the letters before the '_' so it should be zh.yml, you can send it on my discord or make a pull request

Annijang commented 2 years ago

你能提供“游戏内NBTEdit”的链接或视频吗? 我可以添加一个命令来编辑块和实体

对于语言,我使用了一个简化的系统,它只使用 '_' 之前的字母,所以它应该是 zh.yml,你可以在我的不和谐上发送它或提出拉取请求

A similar mod is "IBE Editor", but since my server doesn't support mods, I can only choose plugins. It would be best if I could have a GUI that can modify language files like IBE. Thank you for your reply. link: https://www.curseforge.com/minecraft/mc-mods/ibe-editor

Annijang commented 2 years ago

Please forgive me if I inadvertently disturb you, thank you.

Annijang commented 2 years ago

I'll send it to you here when I do it. I'm not very good at using github, so I can't pr. Please forgive me, sorry.

emanondev commented 2 years ago

ok, i'll add something like /entityedit or a tool, which opens a gui to edit entity property like attributes, inventory, and other stuff like ia (on/off), invincibility, persistance etc...

you did not disturb me, i like your ideas ;-)

Annijang commented 2 years ago

Thanks, is it possible to add a new language at the bottom of an existing file? This way I don't have to worry about losing the new language by modifying the existing language files, remember to set them one that requires administrator privileges, so as not to let players open this editing interface and affect the game balance .

emanondev commented 2 years ago

i'm not sure if i did understand:

if you wish to add a new language you can add a new file to languages folder the plugin automatically assign the matching language to the player (if no language do match default language is used) to match the language the plugin peeks into clientside language and consider the lecters before the "_" so both en_us and en_uk match the file en.yml similar to that zh_hk and zh_cn match the file zh.yml, to add zh_cn language you just have to add zh.yml, copy the messages from en.yml and translate them

if you wish to add a language backup file you can put it inside languages folder and add at least a "_" to the file name, then the file would be ignored by the plugin

if you did mean new language messages which are added with plugin updates, you should not worry too much abouth them: those messages are automatically added to language files, a look once in a while when updating should be enough to notice them and fix the translation

Annijang commented 2 years ago

Ok, thank you, I get it, you're busy first, I'm not in a hurry

emanondev commented 2 years ago

The command to edit entities would require a while, i need to add a gui and think of how make it works, also backward compability etc.. so yes it's gonna take a while

for the language file, feel free to send it when you can, i can add it in a few minutes ;-)

Annijang commented 2 years ago

Ok thank you, I will continue to pay attention, I will make the language file first~~