search

emanuele-f / PCAPdroid

No-root network monitor, firewall and PCAP dumper for Android
https://emanuele-f.github.io/PCAPdroid
GNU General Public License v3.0
2.43k stars 286 forks source link

Add stats for IPv6 traffic #421

Closed myzhan closed 8 months ago

myzhan commented 8 months ago

I need to know the IPv6 traffic percentage. For convenience, I add it to the CaptureStatus textview. Not sure it's appropriate or not. Please let me know if there is a better place. And translations are needed.

image

image

emanuele-f commented 8 months ago

Hi @myzhan, thanks for this contibution. I would only add the stats to the Stats activity, not to the StatusFragment. Is this enough for your needs?

myzhan commented 8 months ago

Hi @myzhan, thanks for this contibution. I would only add the stats to the Stats activity, not to the StatusFragment. Is this enough for your needs?

OK, I will move the percentage to the Stats activity later.

myzhan commented 8 months ago

OK, I have moved it to the StatsActivity.

image

emanuele-f commented 8 months ago

@myzhan I've done some small changes. Last question, do you really need decimals in the IPv6 traffic percentage (e.g. 65.77%) or without decimals (e.g. 66%, or 66.8%) it's ok for you? By removing the decimals, it can be consistent with the heap and memory usages percentages.

2024-03-11_17-37

myzhan commented 8 months ago

Both 66% and 66.8% are ok.

Emanuele Faranda @.***>于2024年3月12日 周二00:38写道：

@myzhan https://github.com/myzhan I've done some small changes. Last question, do you really need decimals in the IPv6 traffic percentage (e.g. 65.77%) or without decimals (e.g. 66%, or 66.8%) it's ok for you? By removing the decimals, it can be consistent with the heap and memory usages percentages.

2024-03-11_17-37.png (view on web) https://github.com/emanuele-f/PCAPdroid/assets/5488003/be245298-c8cd-4efc-ba0b-8d76df25b9d8

— Reply to this email directly, view it on GitHub https://github.com/emanuele-f/PCAPdroid/pull/421#issuecomment-1988883565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHI3NLAHDVSKKEKDG7X2IDYXXMWZAVCNFSM6AAAAABEMJ2LPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYHA4DGNJWGU . You are receiving this because you were mentioned.Message ID: @.***>

emanuele-f commented 8 months ago

Good, I will modify this