Don't rewrite if there's no attribute value

emanuele45 / prettyurls

Automatically exported from code.google.com/p/prettyurls

Other

0 stars 0 forks source link

Don't rewrite if there's no attribute value #60

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. Install PrettyURLs
2. Enable PrettyURLs
3. Try to toggle top bar to shrink, and expand will export code and try to
link to page.

What is the expected output? What do you see instead?
"onclick="mainHeader.toggle();" is sent to the address bar and the page is
not found.

What version of the mod, and what version of SMF are you using?
Powered by SMF 2.0 RC1 

What other mods do you have installed?
None

Please provide any additional information below.

Please contact matt@modelitup.com if you resolve this issue, or have any
fix's that I may take into my own hands to resolve.

Thank you for creating this mod, its come in handy many times.
(First time attempting on 2.0 RC1)

Original issue reported on code.google.com by matthew....@gmail.com on 27 Mar 2009 at 3:05

GoogleCodeExporter commented 8 years ago

Can you give me a link to a page with this problem please.

Original comment by curiousdannii on 27 Mar 2009 at 2:51

GoogleCodeExporter commented 8 years ago

http://fullhousesecurity.com/information/

Original comment by matthew....@gmail.com on 27 Mar 2009 at 11:17

GoogleCodeExporter commented 8 years ago

That's cause your code is this:

<a href= onclick="mainHeader.toggle(); return false;">

Change it to:

<a onclick="mainHeader.toggle(); return false;">

Original comment by curiousdannii on 28 Mar 2009 at 12:15

Changed state: Invalid

GoogleCodeExporter commented 8 years ago

what file would I need to edit?

This is only incorrect when I have the program enabled.

Original comment by matthew....@gmail.com on 28 Mar 2009 at 12:48

GoogleCodeExporter commented 8 years ago

index.template.php probably.

And no, it's incorrect at all times, you're just lucky it works ;) Check your 
code
with a HTML validator.

Original comment by curiousdannii on 28 Mar 2009 at 1:25

GoogleCodeExporter commented 8 years ago

Though I guess I could maybe stop it rewriting if immediately after the = is a 
space...

Original comment by curiousdannii on 29 Mar 2009 at 2:39

Changed title: Don't rewrite if there's no attribute value
Changed state: Considering
Added labels: Priority-Low
Removed labels: Priority-Medium

GoogleCodeExporter commented 8 years ago

Need to get this stuff fixed soon.

Original comment by curiousdannii on 27 Apr 2009 at 7:50

Added labels: Milestone-1.0, Priority-Medium
Removed labels: Priority-Low

GoogleCodeExporter commented 8 years ago

Fixed in R96. Unintended bug introduced by issue 40.

Original comment by curiousdannii on 6 May 2009 at 11:42

Changed state: Fixed