search

emanuele45 / prettyurls

Automatically exported from code.google.com/p/prettyurls
Other
0 stars 0 forks source link

Certain URLs shouldn't be absolutivised #75

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Emails get rewritten wrongly, and weirdly. Not sure how they get rewritten
as they do.

Original issue reported on code.google.com by curiousdannii on 20 Jun 2009 at 8:21

GoogleCodeExporter commented 8 years ago 
This is more generic than just email links... JS links need to be left alone,
fragments, and SSI.php calling pages. The absolutivising code must be revised, 
as
well as the code that adds <base>.

Original comment by curiousdannii on 21 Jun 2009 at 2:58

GoogleCodeExporter commented 8 years ago 
Issue 77 has been merged into this issue.

Original comment by curiousdannii on 21 Jun 2009 at 2:59

GoogleCodeExporter commented 8 years ago 
Issue 76 has been merged into this issue.

Original comment by curiousdannii on 21 Jun 2009 at 3:00

GoogleCodeExporter commented 8 years ago 
Issue 78 has been merged into this issue.

Original comment by curiousdannii on 21 Jun 2009 at 3:00

GoogleCodeExporter commented 8 years ago 
Fixed in r126. I needed to make the checks for adding $boardurl a lot more
complicated, but it works now.

However, it doesn't seem like <base> will be usable, as it not only applies for
relative URLs but fragments as well. Oh well.

Original comment by curiousdannii on 22 Jun 2009 at 3:57

GoogleCodeExporter commented 8 years ago 
I don't think this is actual fix. 

i use this code <a href="?theme=48;variant=beyaz"><img></a>

This code should work in all page.
But this image linked boardurl/?theme=48;variant=beyaz always.
Actually should work if i go to my topic "site.com/board/topic/?
theme=48;variant=beyaz"

Original comment by vazgec on 22 Jun 2009 at 10:14

GoogleCodeExporter commented 8 years ago 
Hmm. Yes maybe that should be changed. We could change it so it will append the 
URL
to the current URL. Same for # fragments, which would then allow me to put the 
<base>
back in. I really want <base> so that relative scripts and images etc will 
still work.

Original comment by curiousdannii on 22 Jun 2009 at 12:35