langCode - Githubissues

emanuelefricano93 / frxjs-Ngx-Timeline

NgxTimeline Angular Library

28 stars 9 forks source link

langCode #13

Closed sysmat closed 2 years ago

sysmat commented 2 years ago

is it possible to have another language support or contribute, we need Slovenian

emanuelefricano93 commented 2 years ago

Hello @sysmat,

https://github.com/emanuelefricano93/frxjs-Ngx-Timeline/blob/master/projects/ngx-timeline/src/lib/models/NgxConfigObj.ts

You can have a look here, and try to add a key for Slovenian language with the date configuration you need. Try to do a PR, in case of issue let me know :)

sysmat commented 2 years ago

The problem is that angular pipe doesn't support it.
I fork it and add it to supportedLanguageCodes, NgxDateObjMap, ...

RROR Error: NG02100: InvalidPipeArgument: 'Missing locale data for the locale "sl".' for pipe 'DatePipe'

sysmat commented 2 years ago

@emanuelefricano93 thx for replay

emanuelefricano93 commented 2 years ago

Hello @sysmat ,

I am applying the support for slovenian and portuguese :) I will release in some minutes.

emanuelefricano93 commented 2 years ago

Version 1.2.3 just released https://www.npmjs.com/package/@frxjs/ngx-timeline Let me know and enjoy the timeline :)

sysmat commented 2 years ago

It works like a charm, thx

emanuelefricano93 commented 2 years ago

Perfect, let's meet in Ljubljana :D, kidding.

Have a nice day!

sysmat commented 2 years ago

Yea, it would be great