search

emanuelhuber / RGPR

Ground-penetrating radar (GPR) data processing and visualisation: a free and open-source software package (R language)
http://emanuelhuber.github.io/RGPR/
162 stars 49 forks source link

code cleanup recommendation #26

Closed cellocgw closed 4 years ago

cellocgw commented 4 years ago

At the top of fitHyperbola, you do a check on the dimensions of x. (when y= NULL). May I suggest instead using the function grDevices::xy.coords instead? It's a bit cleaner.

emanuelhuber commented 4 years ago

Thank you very much for your suggestion. I was not aware of the function grDevices::xy.coords (we can always learn something new). I updated the function hyperbolatFit accordingly. Don't hesitate to share any suggestions.