emanzione / PATCH

The PATCH repository for issues tracking, wiki and shared material.
https://assetstore.unity.com/packages/tools/utilities/p-a-t-c-h-ultimate-patching-system-41417
MIT License
47 stars 7 forks source link

Dropbox Feature is outdated #53

Open LukasFratzl opened 2 years ago

LukasFratzl commented 2 years ago

The Dropbox feature has 2 major issues:

  1. It does not work out of the box, it requires adding another method into the “DropboxDownloader” -> public override void Download(string url, string destFolder, Action<long> onChunkDownloaded) and this method is when we convert it 1 to 1 to Dropbox Code not multithreaded.

  2. Dropbox got a Terms of Service Update back in September 2021 which changes the OAuth workflow, the new workflow says it's no longer possible to create “Long living Tokens” but the App can request an “Short living Token” from the Dropbox Server which can be used as temporary credentials while using the patcher. Here is an example in c# of the new OAuth workflow Github Dropbox API Example. Using just an “Short living Token” makes the patcher not connect any more after some hours with the same token.

I'm currently editing the Files for my own game so once I've done it I can send a Pull Request or sharing the Code to the PATCH Authors to review and use.

RobbyWD commented 1 year ago

Hey there Lukas, could you please send me the working examples of the DropboxDownloader please? Can't make it work properly. Thanks!