search

emaphp / underscore-template-loader

A Underscore and Lodash template loader for Webpack
MIT License
104 stars 24 forks source link

Webpack 5 compatibility #42

Closed idudinov closed 1 year ago

idudinov commented 3 years ago

The main change here was to get rid of custom file-loader usage. Of course I'm not aware why it was initially introduced, but from my findings and use cases the removal doesn't break anything but makes our codebase work as it was for webpack 4. I'd appreciate any feedback on this suggestion.

hirbod commented 3 years ago

While I did not encounter any issues with webpack 5 before, this PR did not break anything for me either.

ryon137 commented 1 year ago

Any reason why this was not merged?

emaphp commented 1 year ago

Any reason why this was not merged?

life

idudinov commented 1 year ago

@emaphp thanks for merging and releasing new version!