Congratulations! 🎉 Your project is complete, and your code is interesting! 🚀
The code provided contains different sections and elements, and your project is well organized. Overall, the code looks fine with a few areas for improvement as optional suggestions that I will address below:
Highlights
Descriptive PR ✔️
Linters passing ✔️
Optional Suggestions 💡
[ ] About the CSS file, you have two "stylesheets"; which can be hard for another developer to understand, I think you can add comments in the READMME.md to explain why.
[ ] You can too nest the desktop and the mobile code in a single file, and use Media Queries to deal with several sizes of screen.
While these comments with the [OPTIONAL] prefix won't prevent the approval of this pull request, I strongly recommend taking them into account as they can improve your code. Some of them were missed by the previous reviewer and addressing them will really enhance your application.
Cheers and Happy coding!👏👏👏
If you have any questions or need clarification on anything, feel free to leave a comment in the pull request thread, and don't forget to tag me so I'll receive the notification.
As per the Code reviews limits policy, you have a limited number of reviews per project. If you feel that the code review was unfair, you can request a second opinion using this form.
Once again, congratulations on completing this project! 🎉
Hi @emarkees ,
Congratulations! 🎉 Your project is complete, and your code is interesting! 🚀 The code provided contains different sections and elements, and your project is well organized. Overall, the code looks fine with a few areas for improvement as optional suggestions that I will address below:
Highlights
Optional Suggestions 💡
[ ] About the CSS file, you have two "stylesheets"; which can be hard for another developer to understand, I think you can add comments in the READMME.md to explain why.
[ ] You can too nest the desktop and the mobile code in a single file, and use Media Queries to deal with several sizes of screen.
While these comments with the [OPTIONAL] prefix won't prevent the approval of this pull request, I strongly recommend taking them into account as they can improve your code. Some of them were missed by the previous reviewer and addressing them will really enhance your application.
Cheers and Happy coding!👏👏👏
If you have any questions or need clarification on anything, feel free to leave a comment in the pull request thread, and don't forget to tag me so I'll receive the notification.
As per the Code reviews limits policy, you have a limited number of reviews per project. If you feel that the code review was unfair, you can request a second opinion using this form.
Once again, congratulations on completing this project! 🎉