emarsden / dash-mpd-rs

Rust library for parsing, serializing and downloading media content from a DASH MPD manifest.
MIT License
70 stars 22 forks source link

Improve keep_audio and keep_video API #26

Closed sleepycatcoding closed 1 year ago

sleepycatcoding commented 1 year ago

Makes keep_video and keep_audio API more useful by allowing consumer to specifiy paths where files should be saved.

TODO

emarsden commented 1 year ago

Thanks, the general principle looks good to me.

A nitpick, perhaps the "Other" error could be made an IoError with a reason similar to "requested audio path is invalid UTF-8"?

sleepycatcoding commented 1 year ago

The problem of making it a IoError is that we need a std::io::Error object.

https://github.com/emarsden/dash-mpd-rs/blob/6a73f89438ab43fa30a63091f7f299b48b0e11f9/src/lib.rs#L106-L107

emarsden commented 1 year ago

OK, thanks!