search

emartech / 3rd-party-integrations-magento-M2

Please note: this plugin is deprecated. we have a new version of the plugin- please contact emarsys support for more info
MIT License
0 stars 5 forks source link

undefined $emarsysApiEventID #11

Closed yohanespradono closed 6 years ago

yohanespradono commented 6 years ago

When emarsys transactional email is disabled, this file throws an error.

Emarsys/Emarsys/Model/SendEmail.php line 325-328

$emarsysEventCollection = $this->emarsyseventsFactory->create()->getCollection() ->addFieldToFilter('store_id', ['eq' => $storeId]) ->addFieldToFilter('event_id', ['eq' => $emarsysApiEventID]);

because $emarsysApiEventID is undefined. It is happening when placing an order.

laurent35240 commented 6 years ago

Hi,

I created PR #29 for fixing this issue. In the meantime you can use my fork by putting these lines in your composer.json file

{
    "require": {
        "emarsys/emarsys": "dev-master"
    },
    "repositories": {
        "emartech-3rd-party-integrations-magento-m2": {
            "type": "git",
            "url": "https://github.com/laurent35240/3rd-party-integrations-magento-M2"
        }
    }
}
eghanin commented 6 years ago

Thank you Yohanes and Laurent. appreciate your support and contribution

eghanin commented 6 years ago

this has been merged