search

emartech / 3rd-party-integrations-magento-M2

Please note: this plugin is deprecated. we have a new version of the plugin- please contact emarsys support for more info
MIT License
0 stars 5 forks source link

Fixing issue #33 by removing dependency to emarsys log in TransportBu… #34

Closed laurent35240 closed 6 years ago

laurent35240 commented 6 years ago

…ilder class

I removed Emarsys log in TransprortBuilder because it caused compilation error if compile code is empty and because it was king of useless in this class.

eghanin commented 6 years ago

Hi Many thanks for this. We will review the changes, and if found suitable, we will merge it in.

Thanks a lot! Guy

eghanin commented 6 years ago

please see : https://github.com/emartech/3rd-party-integrations-magento-M2/pull/35

this is our suggested fix for the issue you're experiencing.

Thanks Guy

laurent35240 commented 6 years ago

I added some reviews on this PR but otherwise it fixes our issue.

Laurent

eghanin commented 6 years ago

Cheers Laurent. Your contribution is appreciated !

eghanin commented 6 years ago

Than you Laurent, We merged our suggested fix to the issue :) and it will be releaaed with our new releaae in a couple of days.

thanks guy