search

emartech / 3rd-party-integrations-magento-M2

Please note: this plugin is deprecated. we have a new version of the plugin- please contact emarsys support for more info
MIT License
0 stars 5 forks source link

Fixing exception "Fatal error: Uncaught Error: Call to a member funct… #41

Closed laurent35240 closed 6 years ago

laurent35240 commented 6 years ago

…ion getStoreId() on string in /app/vendor/emarsys/emarsys/Model/Template.php:90"

This fix an exception we got when creating a company account on Magento 37460196-cea96c5a-284a-11e8-9f4c-7abc70a09819

eghanin commented 6 years ago

Hi Laurent, Thanks for this. Could you share with me the Magento version and Plugin version you're working with ?

Thanks very much .. Guy

laurent35240 commented 6 years ago

Hi,

We are working with Magento Enterprise 2.2.3 and we use version from master of your github repository (currently version 1.0.9)

Regards, Laurent

eghanin commented 6 years ago

Thank you laurent.

Guy

laurent35240 commented 6 years ago

Hi

Why did you close this PR without merging it? Did you find another solution for this issue?

Laurent

eghanin commented 6 years ago

Hi Laurent, We actually did take your changes and merged them with other changes we did. Our Dev team told me it was added to another PR , but I am not sure exactly which one ( we had 36 commits in the passed 2 weeks . In any case, you're changes are always taken seriously!

Thanks very much ! Guy