emartech / escher-js

Library for HTTP request signing (JavaScript implementation)
MIT License
12 stars 11 forks source link

Date is cached in constructor #5

Closed sonicoder86 closed 6 years ago

sonicoder86 commented 8 years ago

If I instantiate the class, it stores the current Date. Problem comes when someone tries to sign a request after minutes of the instantiation, will get an expires message from the receiving part.

boogie commented 8 years ago

It is a known issue, all Escher implementations work like this. Pull requests are welcome, it would be great to see it fixed. :)

ejstrobel commented 7 years ago

I had the same problem in the java/scala lib. This was a huge pain to debug, since it works fine in tests and stops working after 15 minutes in production.

boogie commented 6 years ago

This commit fixes the issue: https://github.com/emartech/escher-js/commit/b844df6f028660acb645f06e9e05ac758c7a98ff

szeist commented 6 years ago

Fixed in release v1.0.0