emartech / escher-js

Library for HTTP request signing (JavaScript implementation)
MIT License
12 stars 11 forks source link

documentation errors #6

Open zkiiito opened 8 years ago

zkiiito commented 8 years ago

I was testing escher, using the documentation form here: https://escherauth.io/escher-js.html

The documentation is wrong, because if I add the 'X-Escher-Date' header, it'll be in a wrong format, and the PHP implementation is not accepting it. If I do not add this header, the library generates it in a correct format. The other error is, that I had to add the 'host' header too, it's not in the example.

ejstrobel commented 7 years ago

@zkiiito : the host header is part of HTTP/1.1 so that's not surprising, but maybe the doc site should mention it requires this version.