Closed adamkarnowka closed 2 years ago
Hi,
Thanks for your request, we'll evaluate it internally and come back with an answer as soon as possible.
The request sounds completely reasonable, however, the plugin and the ecosystem around it was built with the mindset, that the Magento is the leading database (which should be replicated to Emarsys). We'll have to check what this change would affect in our existing user base and make our decision based on that.
Thanks, Balazs
Hi, thanks for your reply - I can totally understand your position and I got official information that it won't be changed, so we'll patch it on our end. I will close the issue in this case.
Kind regards Adam
Hello, we've found out that in some scenarios, data loss in Emarsys is possible. Assuming that:
When registering and going through DOI process - it will generate such payload to be updated in Emarsys (taken from
emarsys_events_data
).As you can see, most of these properties are missing any information, because we don't have them during registration - as a result - data we had before in Emarsys will be overriden with empty values.![image](https://user-images.githubusercontent.com/511845/162018637-b1d0858d-623d-4f76-a776-06e91f3f1d12.png)
In my opinion, if values are empty, they should not be included in payload. Only data fetched directly from customer should override data in Emarsys (for example
lastname
).I can prepare PR for this change, if you decide to include this change. If not, I will create plugin in our code to change this behaviour. Please let me know.
Cheers, Adam