search

emartech / magento2-extension

Emarsys Magento2 Extension
MIT License
11 stars 9 forks source link

Resolve Product helper issues #26

Closed edvardsr closed 1 year ago

edvardsr commented 1 year ago

As the getProductUrlSuffix function must return a string, and sometimes the product url suffix might be null, the config value must have its type set to string

dimitrovn commented 1 year ago

@tamasperencz is this needed in the v2.0.1 ?

edvardsr commented 1 year ago

Just in case - this PR and #27 both resolve issues I encountered while using v2.0.1.

dimitrovn commented 1 year ago

@edvardsSW

thanks! we are testing the correction and going to produce v2.0.2 with it.