search

emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
648 stars 42 forks source link

Doesn't work on gnome 3.38 #110

Closed pstolarz closed 3 years ago

pstolarz commented 3 years ago

Since ui.tweener module is removed in gnome 3.38 (see here for details), the extension doesn't work on this version of shell.

Changing Tweener import in tiling.js (line 7) from const Tweener = imports.ui.tweener; to const Tweener = imports.tweener.tweener; fixed the problem.

emasab commented 3 years ago

Hi, thanks for your contribution! I've included the fix in the last commit. Tell me if there are other problems with the last version of GNOME.

https://github.com/emasab/shelltile/commit/1b63126a112861d964873b812f6af31b3a063fc6

pstolarz commented 3 years ago

Thanks for quick fix. Unfortunately there is a small issue with it. #111 contains proper version. As far as everything works fine on 3.38. Thanks for the great extension. Good job.

emasab commented 3 years ago

Please try the latest version on master, it's only a bit different from your PR for backward compatibility reasons

pstolarz commented 3 years ago

Works fine, thanks.

meeas commented 3 years ago

Confirmed everything working fine with Master on Debian Sid with Gnome 3.38. I think the only thing missing is adding 3.36 and 3.38 to metadata.json and pushing it up to Gnome Extensions website.

emasab commented 3 years ago

Done, thanks for the reminder