emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
647 stars 42 forks source link

Odd results with multiple monitors #17

Closed bongfrog closed 7 years ago

bongfrog commented 7 years ago

Thanks for a great extension. I am having some issues with this extension when my laptop is connected to an external monitor. It seems that the screen edge triggers one the second monitor result in the window jumping back to the primary. The shaded window that shows position are drawn on the primary.

I do want to remark that I am running Gnome on Fedora 25 with Wayland and will test with X11 when I get a chance.

Thanks again

Hjdskes commented 7 years ago

Can confirm that this extension does not behave as it should on Wayland with two monitors.

ehuisman commented 7 years ago

It doesn't work with two monitors without Wayland (with X, that is), either. I did some testing and it seems that at least for me, the problem is connected to the fact that I have the external display is configured as the primary even though it has assigned number 2. If I switch my laptop display to be the primary, this extension works as expected on both screens.

ehuisman commented 7 years ago

Screenshot as requested:

shelltile

emasab commented 7 years ago

Thanks, I've reproduced the problem, but don't know the cause yet.

bongfrog commented 7 years ago

Good morning.
My tests with X11 had other issue with multiple monitors so I did not complete but in Wayland I wanted to point out a very interesting fact that I noticed. When I attempt to position a window on one of the monitors the "target area" actually shows up on the opposite monitor and the window lads there as well. Monitor 1 (laptop display) is my primary and 2 is a 4K TV in service as a monitor. As I said I am able to make use but draging a window to the opposite monitor is not idea.

Once again thanks for your hard work. screenshot from 2017-01-26 09-04-05

bongfrog commented 7 years ago

FYI This appears to be a little deeper of a Wayland type issue as I am also noticing that QUAKE's display screen setting does not seem to be respected as well. When the setting is for primary monitor the drop down appears on either randomly.

Thanks again

VinnyFonseca commented 7 years ago

I have a laptop with an external monitor plugged in via mini displayport. For me, the issue is that I set the external monitor to primary and the laptop one to secondary.

It seems the extension is using another parameter to detect which is which. When I set my laptop monitor to primary, it worked with no issues, but the my dock and panel go to my laptop monitor and it's not ideal for me.

Using X here.

emasab commented 7 years ago

Yes, it's related to the primary setting

VinnyFonseca commented 7 years ago

Did you know this before, or is it something I shone some light on? Any ideas for a possible fix?

emasab commented 7 years ago

I had verified it when I've reproduced the bug, but I have to work on the code to find the solution.

VinnyFonseca commented 7 years ago

Cool, thanks. Keep us posted :)

emasab commented 7 years ago

this should be solved by the latest changes on the master branch

VinnyFonseca commented 7 years ago

Thanks, will test it tomorrow and let you know.

mhellmeier commented 7 years ago

Thanks a lot. I tested it on Ubuntu 16.04 with GNOME Shell 3.18.5 and it works.

I think there are still problems with grouping and two monitors. Sometimes the group jumps to the other screen, sometimes I can't create a group (yes, I am using the CTRL key).

It is also hard to create a single split screen with two windows on one monitor: I must go to a corner (because I don't want to put the window on the other screen), but the extensions thinks that I want to place four windows on a screen.

I can create another issue for that, if you want.

VinnyFonseca commented 7 years ago

Thanks @emasab, working flawlessly now. Ubuntu 16.04 and GNOME Shell 3.20.4. I haven't encountered the issues @mhellmeier found, but that's anecdotal. Any idea when will the update be available on gnome.extensions.org?

emasab commented 7 years ago

there is a new version on extensions.gnome.org, waiting for approval

bongfrog commented 7 years ago

I just was able to get my Shelltile updated to the version on gnome.org and it seems to have corrected the issues I was having (wayland / multiple monitor). Windows are moving to the correct screen , the control groupings actually seem to work now. Thanks for all of the hard work!!!

On 03/06/2017 01:57 AM, emasab wrote:

there is a new version on extensions.gnome.org, waiting for approval

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emasab/shelltile/issues/17#issuecomment-284337633, or mute the thread https://github.com/notifications/unsubscribe-auth/AFMEoPVFYjSj728sO59pdX3OhdP7vqYNks5ri8qGgaJpZM4Li5oP.