emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
647 stars 42 forks source link

Don't arbitrarily change keybindings #39

Closed btittelbach closed 7 years ago

btittelbach commented 7 years ago

Hi,

That is really bad behaviour and sours the experience of what would otherwise be a very helpful tool.

emasab commented 7 years ago

Do you have the latest version ? I've removed the keybindings.

detly commented 7 years ago

I had the same problem (with meta+L for locking the screen) and updating fixed it 👍

btittelbach commented 7 years ago

I have the newest version. I can see where the keybindings were commented out in the code.

Issue remains though!

The moment I activate shelltile, my keybindings for Maximize/Restore Window are reset to Super-Up/Down and remain unchangeable while the extension is active. I can confirm that this is the behaviour of the newest version, that I restarted several times in between and that no legacy shelltile code is lying around somewhere.

My custom-settings for Maximize/Restore Window is to remove the keybind aka no key is bound to these functions

emasab commented 7 years ago

Ok, now I understand what's happening. When I've removed the keybindings I've added a piece of code that upon activation resets those values to the defaults, because the previous version removed the default keybindings in order to overwrite them. I have to keep that code for some time, if you want to overwrite those keybindings remove these lines in

~/.local/share/gnome-shell/extensions/ShellTile@emasab.it/extension.js

self.keybindingSettings.reset("maximize");
self.keybindingSettings.reset("unmaximize");
self.keybindingSettingsMutter.reset("toggle-tiled-left");
self.keybindingSettingsMutter.reset("toggle-tiled-right");
emasab commented 7 years ago

or you can set those values to the default, so that reset will always revert to those values, following this tutorial

https://askubuntu.com/questions/65900/how-can-i-change-default-settings-for-new-users

btittelbach commented 7 years ago

I tried changing the default values which worked fine and does not interfere with semiautomatic shelltime upgrades.

Glad I can finally use shelltile without hassle :-) Still looking forward to a more permament solution though.