search

emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
648 stars 42 forks source link

The 'Super' key behaves like the 'Control' (it's a problem sometimes) #40

Closed DLakomy closed 7 years ago

DLakomy commented 7 years ago

When I move a window with the 'Super' key pressed, the extension's behaviour is the same as if I kept the 'Control' pressed - tiling is enabled. It's a problem for me, since I use 'Super'+LeftMouseButton to move windows. I use Gnome 3.22.2. I think one should be able to choose which key they want to use.

jedypod commented 7 years ago

This is an issue for me as well... Reverting to a previous version until this is fixed.

ntkoopman commented 7 years ago

I'm pretty sure I saw this in another issue, but you can work around this by modifying ~/.local/share/gnome-shell/extensions/ShellTile@emasab.it/tiling.js: On line 595 change 

var modifiers = Clutter.ModifierType.CONTROL_MASK | Clutter.ModifierType.MOD4_MASK;

to

var modifiers = Clutter.ModifierType.CONTROL_MASK;

But a configuration option would be nice.

edit: Don't forget to restart gnome-shell after the change (Press Alt + F2 and type r if you are on xorg, or restart your session on wayland)

RicardoEPRodrigues commented 7 years ago

I made a still open issue. #34

lagerspetz commented 7 years ago

This is affecting me too. I use Inkscape to draw vector graphics, and it makes heavy use of alt and ctrl, so my window move modifier is Super, not Alt. Moving windows with Super - Left drag makes them tile, even though the documentation for this widget specifies Ctrl. Ctrl is great in my opinion. If you want to enable other keys too, please let people change that.

lagerspetz commented 7 years ago

I just made a pull request for this: https://github.com/emasab/shelltile/pull/42

emasab commented 7 years ago

Hi, I've heard your complains and remove the usage of the super key. It was introduced along with the super+keys shortcuts, but given that shotcuts have been removed, I remove it too. It will come back if configurable and the shortcuts would have to be configurable too. I've pushed the commit and the new version is on gnome shell.