search

emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
648 stars 42 forks source link

add preference item to disable edge-tiling at top of screen #56

Closed dberner closed 6 years ago

dberner commented 6 years ago

I prefer not to have top edge tiling active because I trigger it accidentally a lot and it becomes annoying.

Added an option in the extension settings to disable (default on).

ddnexus commented 6 years ago

@dberner: Please, take a look at https://github.com/emasab/shelltile/pull/59. That fix makes the "accidental" problem totally go away so it looks like there is no need to disable the top edge. Please, let me know if it works for you.

dberner commented 6 years ago

@ddnexus : I updated to the current master, 394c1fd, with the smaller EDGE_ZONE_WIDTH, but it's still triggering unintentionally.

It's the Fitts' law thing, the top edge is infinite so when I move a window up, an accidental trigger is likely. In Unity you could just turn it off for the top edge.

ddnexus commented 6 years ago

Yeah. That is not my original PR #59 commit (please read my last comment in #59), but the one modified by @emasab with an edited EDGE_ZONE_WIDTH = 5. Please, edit the EDGE_ZONE_WIDTH = 1 and let us know if it works as you would like.

dberner commented 6 years ago

It's easier to control when set to 1, but I still prefer an option to turn it off entirely. I don't have accidental trigger because I can back out more easily but I still have the preview flashing at me when I don't want it to.

ddnexus commented 6 years ago

Does "easier to control when set to 1" means that the unwanted behavior can still be triggered accidentally or not?

On Sat, May 19, 2018, 9:28 AM dberner notifications@github.com wrote:

It's easier to control when set to 1, but I still prefer an option to turn it off entirely. I don't have accidental trigger because I can back out more easily but I still have the preview flashing at me when I don't want it to.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/emasab/shelltile/pull/56#issuecomment-390372107, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGJcejwT4kJHm0aetnbYVXH75T5x_f0ks5tz4M6gaJpZM4Tsgwu .

ddnexus commented 6 years ago

@dberner: sorry, I just read that you "don't have accidental trigger" with EDGE_ZONE-WIDTH = 1 . Thanks. @emasab: It looks like the 5 in place of 1 still causes problems. Please, reconsider the EDGE_ZONE-WIDTH = 1. Thanks.

emasab commented 6 years ago

Sorry but I cannot accept this pull request. This is too specific for the behavior you want and I've not received this request of disabling only the top edge tiling from other people. If I accept this I could receive other requests for disabling only the left edge tiling, the right one etc.

I've added an option to disable edge tiling entirely , with the possibility to use only the window grouping behavior from ShellTile and the default edge tiling from Gnome Shell. I've also set EDGE_ZONE_WIDTH to 1

Thanks for your interest and contribution!