search

emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
648 stars 42 forks source link

Update for gnome 3.30 #68

Closed martin31821 closed 5 years ago

martin31821 commented 5 years ago

This PR updates the extension to the gnome 3.30 API, I don't know since which gnome shell version the API I used exists.

Furthermore I removed whitespaces in empty lines. This PR fixes #66

AlexWayfer commented 5 years ago

Furthermore I removed whitespaces in empty lines.

Please, add an EditorConfig file, or this situation will be repeated with a more probability.

Or don't remove whitespaces when you update to the new version of Gnome — these are different tasks. Especially in a single commit.

martin31821 commented 5 years ago

Please, add an EditorConfig file, or this situation will be repeated with a more probability.

I definitiely agree with you here, but that should be done by the maintainer.

AlexWayfer commented 5 years ago

I definitiely agree with you here, but that should be done by the maintainer.

You can suggest, maintainer can accept or reject your suggestion. Just like another changes.

emasab commented 5 years ago

Thanks, I'm going to copy your changes, add a tiny compatibility class for previous versions and at the end add an EditorConfig to facilitate contributions. I'll do the compatibility checks with duck typing, I think It's the safest way

emasab commented 5 years ago

changes included in https://github.com/emasab/shelltile/commit/441c0974f2045cc36a23beccd1b2d67e2fa05ba1

along with all the editorconfig edits

Tell me if everything's ok, I've tested it on 3.30 and 3.18

martin31821 commented 5 years ago

Works fine @emasab