search

emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
645 stars 42 forks source link

Use GNOME Shell colors instead of hard-coded colors in tiling overlay #70

Closed javierbg closed 6 years ago

javierbg commented 6 years ago

This modification changes the color of the tiling overlay from a hard-coded value to the one set by the GNOME Shell theme currently in use.

To accomplish this, it uses the CSS class tile-preview, just like the default tiling for GNOME, instead of grid-preview, which was defind in stylesheet.css (no need for :activate now).

This was addressed in the discussion of issue #21.

javierbg commented 6 years ago

Oops, i just realized that my editor might have deleted some whitespace on empty lines, I hope that's not a problem.

AlexWayfer commented 6 years ago

Oops, i just realized that my editor might have deleted some whitespace on empty lines, I hope that's not a problem.

  1. I'm against whitespace changes in PRs not about whitespaces (but I'm not collaborator).
  2. I think it should be managed by EditorConfig, and config file in this project can be tuned (in a separate MR), also plugin for this should be turned on in your editor.
emasab commented 6 years ago

Thanks for the contribution, this is the elegant solution I was looking for. Could you rebase the commit to the master and run build.sh eclint before committing (with eclint installed)

javierbg commented 6 years ago

That should be good?