emasab / shelltile

A tiling window extension for GNOME Shell
https://extensions.gnome.org/extension/657/shelltile/
GNU General Public License v2.0
645 stars 42 forks source link

Grouped windows stay maximized when opening activities. #77

Closed FrantisekHruska closed 4 years ago

FrantisekHruska commented 5 years ago

I have been expereiencing this bug when I open activities menu. Grouped windows stay maximized and get cropped. snimek z 2019-02-23 11-51-00 The bug dissapeared after removing and reinstalling the extension but only until I restarted gnome shell.

I am on Ubuntu 18.04.2 with gnome 3.28.3

moshemalawach commented 4 years ago

Same issue here, no way to get it to work, it stays maximized... Ubuntu 19.10 :(

moshemalawach commented 4 years ago

If I uninstall and reinstall it works, until gnome restarts and I need to redo the same.

myralchista commented 4 years ago

same here. pure gnome on arch.

Screenshot from 2019-12-10 17-33-38

Usually happens when 3 windows are tiled. drugging / changing / resizing windows helps to fix it.

emasab commented 4 years ago

@C0dyCZ @moshemalawach @myralchista There is some sequence of actions that can be used to reproduce the problem systematically? could you run:

ps ax | egrep '(Xorg|Xwayland)'
myralchista commented 4 years ago

My output of command

ps ax | egrep '(Xorg|Xwayland)'

   652 tty1      S+     0:00 /usr/lib/Xorg vt1 -displayfd 3 -auth /run/user/120/gdm/Xauthority -nolisten tcp -background none -noreset -keeptty -verbose 3
   1052 tty2     S+     1:08 /usr/lib/Xorg vt2 -displayfd 3 -auth /run/user/1000/gdm/Xauthority -nolisten tcp -background none -noreset -keeptty -verbose 3
   9755 pts/0    S+     0:00 grep -E (Xorg|Xwayland)

There is some sequence of actions that can be used to reproduce the problem systematically?

The easiest way to reproduce is to open 2 windows of chromium. Tile one on left side, another on right, then open another new window of chromium (without tiling it) and press on Activities.

moshemalawach commented 4 years ago

Also, started happening on the same system when I started using a screen of 2560x1080, didn't happen before.

-------- Message d'origine -------- On 11 déc. 2019 à 14:43, myralchista < notifications@github.com > a écrit :

My output of command

ps ax | egrep '(Xorg|Xwayland)'

652 tty1     S+     0:00 /usr/lib/Xorg vt1 -displayfd 3 -auth /run/user/120/gdm/Xauthority -nolisten tcp -background none -noreset -keeptty -verbose 3

1052 tty2 S+ 1:08 /usr/lib/Xorg vt2 -displayfd 3 -auth /run/user/1000/gdm/Xauthority -nolisten tcp -background none -noreset -keeptty -verbose 3 9755 pts/0 S+ 0:00 grep -E (Xorg|Xwayland)

There is some sequence of actions that can be used to reproduce the problem systematically?

The easiest way to reproduce is to open 2 windows of chromium. Tile one on left side, another on right, then open another new window of chromium (without tiling it) and press on Activities.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.AJXOYW4FJKUGC6HCYDHSZXTQYDU7PA5CNFSM4GZXQYEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGTEXZI.gif

myralchista commented 4 years ago

I use 2560x1080 widescreen monitor too.

emasab commented 4 years ago

reproduced on GNOME Shell 3.34.1, the error: JS ERROR: TypeError: b.windowCenter is undefined computeLayout/<@resource:///org/gnome/shell/ui/workspace.js:1039:38 computeLayout@resource:///org/gnome/shell/ui/workspace.js:1039:9 _getBestLayout@resource:///org/gnome/shell/ui/workspace.js:1945:13 _computeLayout@resource:///org/gnome/shell/ui/workspace.js:1989:16 OverviewModifier310/this.computeLayout@/home/virtualbox/.local/share/gnome-shell/extensions/ShellTile@emasab.it/overview.js:629:22 OverviewModifier.register/GSWorkspace.prototype._computeLayout@/home/virtualbox/.local/share/gnome-shell/extensions/ShellTile@emasab.it/overview.js:731:20 _realRecalculateWindowPositions@resource:///org/gnome/shell/ui/workspace.js:1293:31 _recalculateWindowPositions/this._positionWindowsId<@resource:///org/gnome/shell/ui/workspace.js:1269:13

emasab commented 4 years ago

fixed in https://github.com/emasab/shelltile/commit/d1fa9ca80083292f75840f5dbce2542f05468e99 tell me if it works for you. Just replace the overview.js in ~/.local/share/gnome-shell/extensions/ShellTile@emasab.it

jamsla commented 4 years ago

Applying d1fa9ca locally fixes the issue for me, thanks.