search

emavgl / oinkoin

Oinkoin is a flutter app for helping you managing your expenses. No internet required.
GNU General Public License v3.0
164 stars 11 forks source link

Feature Request: Set decimal places #10

Closed ika-musuko closed 1 year ago

ika-musuko commented 1 year ago

I live in a country (Japan) that typically doesn't use "decimals" or "cents" in the currency. Everything is just whole numbers.

So seeing values like e.g. "947.00" and "12345.00" all the time instead of just "947" and "12345" is visual noise in my case.

I would like some setting where I can configure the amount of decimal places shown in the app. Or at least be able to turn off the decimal places and only show whole values.

emavgl commented 1 year ago

Hello, thanks for the feedback. In which language do you have your smartphone?

emavgl commented 1 year ago

Hi @ika-musuko, I have just pushed a new version 1.0.23 with the option to select the number of decimal digits. You can find that option in the customization page. I am closing this issue but you should be able to comment for further feedback. I'd appreciate if can rate the app on the Play Store or just sharing it with your friends. Have a nice day! :)

ika-musuko commented 1 year ago

Thanks for the quick update @emavgl! Works great and looks as expected.

My phone is set to Japanese, though I believe Oinkoin does not support Japanese so I just see the English user interface. This is fine by me, but I could provide a (starting point) for a Japanese translation if you want. (And then hopefully a native Japanese person can come and correct it 😂)

Gave you a good rating in the Play Store btw (I initially downloaded the app from F-Droid though lol)

emavgl commented 1 year ago

Thanks for checking and for the rating, appreciated :) I am totally not familiar with Japanese language but you are more than welcome in contributing by creating a PR. Supporting a new language should be quite easy (if the UI does not have to change to support it). You can do it just by changing the i18n files and adding a new translation for each string in these files.

nizarus commented 1 year ago

Hi, please consider to add the possibility to get 3 decimals. Here in Tunisia we use that.

emavgl commented 1 year ago

Hi @nizarus, thanks for pointing this out. I'll take it in mind when reworking the currency locales soon!

emavgl commented 1 year ago

Hi @nizarus,

Thanks again for the suggestions. I have just released the version with a new system for visualizing the amount. You can also choose 3 decimals now.

I would be happy if you can give it a try: https://github.com/emavgl/oinkoin/releases/tag/1.0.25

It may take some time before it arrives at the Google Play Store and even more for F-droid.

Have a nice day, Emanuele

nizarus commented 1 year ago

Hi @emavgl, Tested and it's OK. Keep the good work.